log consumer opens, closes, and exceptions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
suggested changes
Jan 8, 2018
| raise e | ||
| end | ||
| rescue => e | ||
| logger.error("uncaught exception in consumer #{consumer_identifier}: #{e}") |
There was a problem hiding this comment.
Can we use structured logging in these places? Logstash loggers let you say:
logger.error("uncaught exception in consumer", :consumer_identifier => consumer_identifier, :message => e.message, :error_class => e.class.name, :error_backtrace => e.backtrace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into reports of slowdowns that are only solved by restarting the pipeline, I discovered that it is possible for an exception to be raised in one of the consumer threads silently (e.g., not raised until we attempt to
jointhe thread).This patch adds useful logging, including that of uncaught exceptions.
It is unverified; there are no tests besides
register, and I don't have a kafka installation yet.